addressing linter errors and cleaning up code

Author: timmarkhuff

src/groundlight/edge/api.py

@@ -18,14 +18,14 @@ def __init__(self, client) -> None:
         self._client = client
 
     def _base_url(self) -> str:
-        return self._client._edge_base_url()
+        return self._client.edge_base_url()
 
     def _request(self, method: str, path: str, **kwargs) -> requests.Response:
         url = f"{self._base_url()}{path}"
         headers = self._client.get_raw_headers()
         try:
             response = requests.request(
-                method, url, headers=headers, verify=self._client.configuration.verify_ssl, **kwargs
+                method, url, headers=headers, verify=self._client.configuration.verify_ssl, timeout=10, **kwargs
             )
             response.raise_for_status()
         except requests.exceptions.HTTPError as e:

src/groundlight/experimental_api.py

@@ -42,7 +42,6 @@
 from urllib3.response import HTTPResponse
 
 from groundlight.edge.api import EdgeAPI
-from groundlight.edge.config import EdgeEndpointConfig
 from groundlight.images import parse_supported_image_types
 from groundlight.internalapi import _generate_request_id
 from groundlight.optional_imports import Image, np
@@ -822,23 +821,7 @@ def make_generic_api_request(  # noqa: PLR0913 # pylint: disable=too-many-argume
             _preload_content=False,  # This returns the urllib3 response rather than trying any type of processing
         )
 
-    def _edge_base_url(self) -> str:
+    def edge_base_url(self) -> str:
         """Return the scheme+host+port of the configured endpoint, without the /device-api path."""
         parsed = urlparse(self.configuration.host)
         return urlunparse((parsed.scheme, parsed.netloc, "", "", "", ""))
-
-    def get_edge_config(self) -> EdgeEndpointConfig:
-        """Deprecated: use ``gl.edge.get_config()`` instead."""
-        return self.edge.get_config()
-
-    def get_edge_detector_readiness(self) -> dict[str, bool]:
-        """Deprecated: use ``gl.edge.get_detector_readiness()`` instead."""
-        return self.edge.get_detector_readiness()
-
-    def set_edge_config(
-        self,
-        config: EdgeEndpointConfig,
-        timeout_sec: float = 600,
-    ) -> EdgeEndpointConfig:
-        """Deprecated: use ``gl.edge.set_config()`` instead."""
-        return self.edge.set_config(config, timeout_sec=timeout_sec)

test/unit/test_edge_config.py

@@ -309,8 +309,8 @@ def test_inference_config_validation_errors():
         )
 
 
-def test_get_edge_config_parses_response():
-    """ExperimentalApi.get_edge_config() parses the HTTP response into an EdgeEndpointConfig."""
+def test_edge_get_config_parses_response():
+    """gl.edge.get_config() parses the HTTP response into an EdgeEndpointConfig."""
     from unittest.mock import Mock, patch
 
     from groundlight import ExperimentalApi
@@ -327,7 +327,7 @@ def test_get_edge_config_parses_response():
 
     gl = ExperimentalApi()
     with patch("requests.request", return_value=mock_response) as mock_request:
-        config = gl.get_edge_config()
+        config = gl.edge.get_config()
 
     mock_request.assert_called_once()
     assert isinstance(config, EdgeEndpointConfig)