Before node build, dont load excluded, inactive or stashed modifications #710
Conversation
Signed-off-by: David BRAQUART <[email protected]>
dbraquart
force-pushed
the
dbraquart/dont-load-modifications-we-wont-build
branch
from
6e87cd1 to
f1a2189
Compare
…odifications-we-wont-build # Conflicts: # src/main/java/org/gridsuite/modification/server/repositories/NetworkModificationRepository.java
Signed-off-by: David BRAQUART <[email protected]>
dbraquart
force-pushed
the
dbraquart/dont-load-modifications-we-wont-build
branch
from
f0bc16e to
42a8cdc
Compare
|
TheMaskedTurtle
left a comment
TheMaskedTurtle
left a comment
There was a problem hiding this comment.
Be careful with the word 'active' because there are already methods that are named 'active' but it fetches only unstashed modifications... and not unstashed and active... which can be confusing. So either remane these other methods or maybe rename yours. Even if yours is correctly named ^^
| List<ModificationEntity> modificationsEntities = getModificationEntityStream(groupUuid) | ||
| .filter(m -> modificationsToExclude == null || !modificationsToExclude.contains(m.getId())) | ||
| .filter(m -> !m.getStashed() && m.getActivated()) | ||
| .toList(); |
There was a problem hiding this comment.
It would be even better to do that in SQL directly. So we don't load unnecessary entities in JPA.
| .stream() | ||
| .filter(m -> modificationsToExclude == null || !modificationsToExclude.contains(m.getId())) | ||
| .filter(m -> !m.getStashed()) | ||
| .toList(); |
There was a problem hiding this comment.
You can remove .stream().toList();
|
Now |
No description provided.