Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Responsive preview to shrink its height regarding to scaled inner iframe #170

Open
softmarshmallow opened this issue Oct 10, 2021 · 0 comments
Assignees

Comments

@softmarshmallow
Copy link
Member

  /* FIXME: this should be a height
  // this should work, but the flex is making inner iframe height to shrink.
  height: max(${(props) => props.heightscale * 100}%, 100%);
    ref:
    - https://stackoverflow.com/questions/51288769/scaling-a-flexbox-child-with-transform-leaves-empty-space
    - https://www.reddit.com/r/css/comments/q5cvei/css_fitcontent_on_parent_wont_work_for_scaled_item/
  */

The height calculation logic is decent, but it seems to be broken due to flex use.
height: max(${(props) => props.heightscale * 100}%, 100%);

This is a known issue, will be included in the production release. It will be fixed in short time.
Screen Shot 2021-10-11 at 3 30 13 AM

Screen Shot 2021-10-11 at 3 30 54 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants