Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(S) Don't see footer on Create New List page #260

Open
gtourtellot opened this issue Sep 8, 2017 · 2 comments
Open

(S) Don't see footer on Create New List page #260

gtourtellot opened this issue Sep 8, 2017 · 2 comments
Assignees
@nsanta
Labels
bug

Comments

@gtourtellot
Copy link
Contributor

No description provided.

@gtourtellot gtourtellot added the bug label Sep 8, 2017
@ptrikutam ptrikutam changed the title Don't see footer on Create New List page (S) Don't see footer on Create New List page Sep 8, 2017
@nsanta
Copy link
Collaborator

nsanta commented Sep 8, 2017

@ptrikutam The bug is caused by AutocompleteSelect component: When the component is mounted, it add the class `no-scroll´ to the body. Any reason of why?

ref:
https://github.com/greencommons/commons/blob/master/app/assets/javascripts/components/autocomplete_select.js.jsx#L14

@ptrikutam
Copy link
Contributor

@ptrikutam The bug is caused by AutocompleteSelect component: When the component is mounted, it add the class `no-scroll´ to the body. Any reason of why?

I'm not sure. @T-Dnzt any why is no-scroll added in that location?

@nsanta - Try removing it and seeing if it breaks anything else where the component is used. Hopefully the specs will cover any use cases anyway and catch issues.

nsanta added a commit that referenced this issue Sep 21, 2017
@nsanta
Issue #260 - Fix display footer on new list page
ba3d0ee
nsanta added a commit that referenced this issue Sep 26, 2017
@nsanta
Issue #260 - Fix display footer on new list page
a0d5964
nsanta added a commit that referenced this issue Sep 26, 2017
@nsanta
Issue #260 - Fix display footer on new list page
c5d0fc6
nsanta added a commit that referenced this issue Sep 26, 2017
@nsanta
Issue #260 - Fix display footer on new list page
044a6a1
nsanta added a commit that referenced this issue Sep 26, 2017
@nsanta
Issue #260 - Fix display footer on new list page (#276)
d59e887
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nsanta nsanta

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nsanta @ptrikutam @gtourtellot