Remove public key auth

Author: Tehforsch

rust/src/nasl/builtin/ssh/libssh/session.rs

@@ -203,26 +203,6 @@ impl SshSession {
         }
     }
 
-    pub async fn auth_public_key(
-        &mut self,
-        login: &str,
-        private_key: &str,
-        passphrase: &str,
-    ) -> Result<()> {
-        self.ensure_user_set(Some(login))?;
-        let key = SshKey::from_privkey_base64(private_key, Some(passphrase))
-            .map_err(|_| SshErrorKind::ConvertPrivateKey.with(self.id))?;
-        let status = self.userauth_try_publickey(None, &key)?;
-        if let AuthStatus::Success = status {
-            return Ok(());
-        }
-        let status = self.userauth_publickey(None, &key)?;
-        if let AuthStatus::Success = status {
-            return Ok(());
-        }
-        Ok(())
-    }
-
     fn get_authmethods(&mut self) -> Result<AuthMethods> {
         let authmethods = match self.userauth_none(None)? {
             AuthStatus::Success => {
@@ -273,7 +253,6 @@ impl SshSession {
     inherit_method!(userauth_none, AuthStatus, UserAuthNone, username: Option<&str>);
     inherit_method!(userauth_list, AuthMethods, UserAuthList, username: Option<&str>);
     inherit_method!(userauth_try_publickey, AuthStatus, UserAuthTryPublicKey, username: Option<&str>, key: &SshKey);
-    inherit_method!(userauth_publickey, AuthStatus, UserAuthPublicKey, username: Option<&str>, key: &SshKey);
     inherit_method!(
         userauth_keyboard_interactive_info,
         InteractiveAuthInfo,

rust/src/nasl/builtin/ssh/mod.rs

@@ -311,15 +311,6 @@ impl Ssh {
                 return Ok(());
             }
         }
-        // If we have a private key, try public key authentication.
-        if session.auth_method_allowed(AuthMethods::PUBLIC_KEY).await? {
-            if let Some(private_key) = privatekey {
-                let passphrase = passphrase.unwrap_or_default();
-                session
-                    .auth_public_key(login, private_key, passphrase)
-                    .await?;
-            }
-        }
         Ok(())
     }
 

rust/src/nasl/builtin/ssh/russh/mod.rs

@@ -19,7 +19,7 @@ pub type Socket = i32;
 
 // This is a 'clone' of the libssh::AuthMethods, so
 // the capital case names are intentional.
-#[allow(non_camel_case_types, clippy::upper_case_acronyms)]
+#[allow(non_camel_case_types, clippy::upper_case_acronyms, unused)]
 pub enum AuthMethods {
     PASSWORD,
     INTERACTIVE,

rust/src/nasl/builtin/ssh/russh/session.rs

@@ -165,22 +165,6 @@ impl SshSession {
             .map(|_| ())
     }
 
-    pub async fn auth_public_key(
-        &mut self,
-        _login: &str,
-        _private_key: &str,
-        _passphrase: &str,
-    ) -> Result<(), SshError> {
-        // TODO: Construct the key pair to provide publickey auth
-        error!("Public key auth not yet supported.");
-        Err(SshErrorKind::Unimplemented.into())
-        // self.session
-        //     .authenticate_publickey(login, key_pair)
-        //     .await
-        //     .map_err(|_| SshError::UserauthPassword(self.id))
-        //     .map(|_| ())
-    }
-
     pub async fn auth_keyboard_interactive(
         &mut self,
         login: &str,