Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate constant value #5

Open
biggianteye opened this issue Feb 2, 2021 · 0 comments
Open

Duplicate constant value #5

biggianteye opened this issue Feb 2, 2021 · 0 comments
Labels
good first issue Good for newcomers

Comments

@biggianteye
Copy link

The Parameter::MINUS_WEIGHT and Parameter::UNDERWEIGHT constants both have a value of 32. It's unclear where these numbers come from and therefore hard to determine if this is correct ir not.

One consequence of this is that the Parameter::idToName array has duplicate indexes for the above constants.

Neither constant appears to be explicitly used by the library at the moment.

    const MINUS_WEIGHT = 32;
    // <skip>
    const UNDERWEIGHT = 32;

    /** @var string[] */
    private static $idToName = [
        // <skip>
        self::MINUS_WEIGHT => 'Minus weight',
        // <skip>
        self::UNDERWEIGHT => 'Underweight'
    ];
@biggianteye biggianteye added the good first issue Good for newcomers label Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant