Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undeclared InvalidArgumentException #40

Open
ivashkevitch opened this issue Oct 25, 2018 · 3 comments
Open

Undeclared InvalidArgumentException #40

ivashkevitch opened this issue Oct 25, 2018 · 3 comments

Comments

@ivashkevitch
Copy link

src/Message/MessageFactory.php contains 2 methods: fromResponse() and createRequest() that can throws undeclared InvalidArgumentException. Fix it, please.

@ivashkevitch ivashkevitch changed the title Undeclared exception Undeclared InvalidArgumentException Oct 25, 2018
@pawel-slowik
Copy link

The InvalidArgumentException class is a part of the Standard PHP Library.

As of PHP 5.3.0 this extension can no longer be disabled and is therefore always available.

The minimum supported PHP version for guzzle-jsonrpc is 5.5:

"require": {
"php": ">=5.5|^7.0",

Therefore, if the InvalidArgumentException class is not declared, you are running guzzle-jsonrpc on an unsupported PHP version.

Therefore, this is not a bug.

@biggianteye
Copy link
Contributor

@ivashkevitch Sorry for not responding sooner. This seems to have fallen through the cracks. It's unclear to me what you asking. Could you clarify?

@ivashkevitch
Copy link
Author

ivashkevitch commented Nov 11, 2019

biggianteye Hi. I mean these methods didn't have @throws annotations and it is unexpected, when it throws exceptions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants