Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dgeni): generate color palettes and render in design-land #2912

Draft
wants to merge 7 commits into
base: develop
Choose a base branch
from
Draft

feat(dgeni): generate color palettes and render in design-land #2912

wants to merge 7 commits into from

Conversation

griest024
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #2905

What is the new behavior?

moves lots of docs stuff to @daffodil/documentation to allow design land to access it too

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@griest024 griest024 added package: daff.io @daffodil/daff.io package: design @daffodil/design status: wip This PR is WIP. It should be marked as a draft. package: docs-utils @daffodil/docs-utils tools: dgeni @daffodil/tools-dgeni labels Jul 15, 2024
@griest024 griest024 changed the title Feat/dgeni/generate color palettes feat(dgeni): generate color palettes and render in design-land Jul 15, 2024
@griest024
Copy link
Member Author

griest024 commented Jul 15, 2024 •
edited
Loading

@xelaint the styling in the design land color component definitely needs some work. I think what I have sufficiently demonstrates how to use the data available though so hopefully you can take it from here

@griest024 griest024 removed their assignment Jul 15, 2024
@xelaint
Copy link
Member

xelaint commented Jul 16, 2024

@griest024 is this PR dependent on #2909 ?

@griest024
Copy link
Member Author

Yes

@griest024 griest024 force-pushed the feat/dgeni/generate-color-palettes branch from cf7d6b8 to af59e88 Compare July 16, 2024 18:57
@griest024 griest024 added status: awaiting review This PR is awaiting review and removed status: wip This PR is WIP. It should be marked as a draft. labels Jul 16, 2024
@griest024 griest024 marked this pull request as ready for review July 16, 2024 18:57
@griest024 griest024 requested review from a team as code owners July 16, 2024 18:57
@griest024 griest024 requested a review from xelaint July 16, 2024 18:57
@xelaint
Copy link
Member

xelaint commented Jul 16, 2024

@griest024 can we remove $error and $daff-white from the autogenerated list? I realized they need to be reworked and should not be part of this color palettes documentation.

@griest024
Copy link
Member Author

@griest024 can we remove $error and $daff-white from the autogenerated list? I realized they need to be reworked and should not be part of this color palettes documentation.

will do, should any single colors ever be part of the generation or only the palettes that contain multiple shades?

@griest024
Copy link
Member Author

I just went ahead and only gened shaded palettes since the implementation is much cleaner

xelaint
xelaint requested changes Jul 17, 2024
View reviewed changes
apps/design-land/src/app/foundations/color/color.component.html Outdated
@@ -124,3 +124,18 @@ <h2>Decorative palettes</h2>
<div style="background-color: #07230d;"><span class="dl-color__hex">100</span><span class="dl-color__hue">#07230d</span></div>
</div>
</div>

<h2>Autogenerated palettes</h2>
<div class="dl-color__decorative-grid">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be moved into its own component in docs-components and added to the /libs/design/guides/color.md readme?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I moved it but the styles are kinda messed up, can you take a look?

@xelaint
Copy link
Member

xelaint commented Aug 12, 2024

@griest024 does this need to be reworked based on the changes Damien made in the last few weeks?

@griest024
Copy link
Member Author

@xelaint yes but afaik those changes aren't all merged yet so I will wait until they are to rebase this.

@griest024 griest024 marked this pull request as draft August 12, 2024 18:02
@griest024 griest024 added status: wip This PR is WIP. It should be marked as a draft. and removed status: awaiting review This PR is awaiting review labels Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xelaint xelaint xelaint requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@xelaint xelaint

Labels
package: daff.io @daffodil/daff.io package: design @daffodil/design package: docs-utils @daffodil/docs-utils status: wip This PR is WIP. It should be marked as a draft. tools: dgeni @daffodil/tools-dgeni
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT] Daffodil Palette Docs Generation
2 participants
@griest024 @xelaint