controllers: return 404 on get network not found #3729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

clwluvw wants to merge 1 commit into gravitl:master from clwluvw:network-404

clwluvw commented Nov 8, 2025

Describe your changes

return http 404 when network is not there rather than an internal err.

Provide testing steps

Call GET /api/networks/{networkname} on a non-existent network to get a 404 rather than a 500 HTTP status code.

Checklist before requesting a review

My changes affect only 10 files or less.
I have performed a self-review of my code and tested it.
If it is a new feature, I have added thorough tests, my code is <= 1450 lines.
If it is a bugfix, my code is <= 200 lines.
My functions are <= 80 lines.
I have had my code reviewed by a peer.
My unit tests pass locally.
Netmaker is awesome.


          controllers: return 404 on get network not found

ac650a7

return http 404 when network is not there rather than an internal err.

Signed-off-by: Seena Fallah <[email protected]>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet