Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About angles #105

Open
dingthuang opened this issue May 2, 2024 · 3 comments
Open

About angles #105

dingthuang opened this issue May 2, 2024 · 3 comments

Comments

@dingthuang
Copy link

Hello, may I ask a question. When loading the dataset, labels for individual objects will be rotated. Only the view has been modified (use knn), but the angle has not been modified. This seems to cause issues with the label angle.

In short, rotation 1 is represented by view1 and angle1, while rotation 2 is represented by view2 and angle2.
Rotate 1 through the rotation matrix to rotate 1 '(Rotate 2).
View 1 rotates the rotation matrix to view 1 (view 2). (in your code knn)
Angle is not assign.
Rotation 1 ' (Rotate 2) cannot be represented by view1' and angle1.

@chenxi-wang
Copy link
Collaborator

chenxi-wang commented May 7, 2024

You are right, in the loss computation, when the predictions of approach vectors are assigned to corresponding labels, we use rotation matrix instead of approach vector + inplane rotation angle to prevent such problems. And, in the training of inplane rotation classification, the cropped points are transformed using corresponding approach vector labels instead of predictions. In this way, the training of view points and in-plane rotations can be decoupled.

@dingthuang
Copy link
Author

1:抱歉,我没有明白你的意思(And, in the training of inplane rotation classification, the cropped points are transformed using corresponding approach vector labels instead of predictions.)。 cropped points 是什么呢?
2:计算inplane 分类时候,你们的代码grasp_angle_class_loss = criterion_grasp_angle_class(grasp_angle_class_score, target_angles_cls),其中target_angles_cls仅仅是来自于单个物体的标签,在转换到场景时候,并没有对其在旋转后重新计算inplane 正确的顺序。(我认为你们应该使用knn,重新计算一下inplane 的顺序)

@chenxi-wang
Copy link
Collaborator

1:抱歉,我没有明白你的意思(And, in the training of inplane rotation classification, the cropped points are transformed using corresponding approach vector labels instead of predictions.)。 cropped points 是什么呢?

指的是 cinlinder grouping 中裁切的点云

2:计算inplane 分类时候,你们的代码grasp_angle_class_loss = criterion_grasp_angle_class(grasp_angle_class_score, target_angles_cls),其中target_angles_cls仅仅是来自于单个物体的标签,在转换到场景时候,并没有对其在旋转后重新计算inplane 正确的顺序。(我认为你们应该使用knn,重新计算一下inplane 的顺序)

这是因为我们把坐标系转换到了单个物体用的坐标系,这样就避免了更繁琐的角度匹配

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants