use dev/prod conditions to set instanceOf check

Author: yaacovCR

cspell.yml

@@ -40,7 +40,8 @@ overrides:
       - tada
       - Graphile
       - precompiled
-      - debuggable
+      - Rollup
+      - Turbopack
 
 validateDirectives: true
 ignoreRegExpList:

integrationTests/README.md

@@ -1 +1,30 @@
-# TBD
+# Integration Tests
+
+This directory contains integration tests for GraphQL.js across different environments and bundlers, testing both development mode and production mode functionality.
+
+## Test Structure
+
+Each subdirectory represents a different environment/bundler:
+
+- `node/` - Node.js runtime tests
+- `deno/` - Deno runtime tests  
+- `bun/` - Bun runtime tests
+- `webpack/` - Webpack bundler tests
+- `rollup/` - Rollup bundler tests
+- `esbuild/` - esbuild bundler tests
+- `vite/` - Vite bundler tests
+- `nextjs/` - Next.js framework tests
+- `create-react-app/` - Create React App tests
+- `swc/` - SWC bundler tests
+
+## Development Mode Testing
+
+Each test verifies:
+1. Development mode is properly enabled (explicit import or conditional exports)
+2. Production mode works without development overhead
+3. Multiple GraphQL.js module detection works in development
+4. Performance characteristics differ between modes
+
+## Running Tests
+
+Tests are run via the main integration test suite in `resources/integration-test.ts`.

integrationTests/dev-bun/package.json

@@ -0,0 +1,10 @@
+{
+  "description": "graphql-js development condition should work with Bun",
+  "private": true,
+  "scripts": {
+    "test": "bun --conditions=development test.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  }
+}

integrationTests/dev-bun/test.js

@@ -0,0 +1,28 @@
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Bun development mode.',
+  );
+} catch (error) {
+  if (
+    error.message ===
+    'Expected isObjectType to throw an error in Bun development mode.'
+  ) {
+    throw error;
+  }
+  if (
+    !(error.message.includes('multiple') || error.message.includes('GraphQL'))
+  ) {
+    throw new Error(
+      `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`,
+    );
+  }
+}

integrationTests/dev-deno/package.json

@@ -0,0 +1,10 @@
+{
+  "description": "graphql-js development condition should work with Deno",
+  "private": true,
+  "scripts": {
+    "test": "deno run --unstable-node-conditions=development test.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  }
+}

integrationTests/dev-deno/test.js

@@ -0,0 +1,28 @@
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Deno development mode.',
+  );
+} catch (error) {
+  if (
+    error.message ===
+    'Expected isObjectType to throw an error in Deno development mode.'
+  ) {
+    throw error;
+  }
+  if (
+    !(error.message.includes('multiple') || error.message.includes('GraphQL'))
+  ) {
+    throw new Error(
+      `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`,
+    );
+  }
+}

integrationTests/dev-esbuild/package.json

@@ -0,0 +1,15 @@
+{
+  "description": "graphql-js development condition should work with esbuild",
+  "private": true,
+  "type": "module",
+  "scripts": {
+    "build": "esbuild src/index.js --bundle --outfile=dist/bundle.js --format=esm --conditions=development,module",
+    "test": "npm run build && node dist/bundle.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  },
+  "devDependencies": {
+    "esbuild": "^0.20.0"
+  }
+}

integrationTests/dev-esbuild/src/index.js

@@ -0,0 +1,28 @@
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in esbuild development mode.',
+  );
+} catch (error) {
+  if (
+    error.message ===
+    'Expected isObjectType to throw an error in esbuild development mode.'
+  ) {
+    throw error;
+  }
+  if (
+    !(error.message.includes('multiple') || error.message.includes('GraphQL'))
+  ) {
+    throw new Error(
+      `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`,
+    );
+  }
+}

integrationTests/dev-node-explicit/bootstrap.js

@@ -0,0 +1,3 @@
+/* eslint-disable import/no-unassigned-import */
+import 'graphql/dev';
+import './test.js';

integrationTests/dev-node-explicit/package.json

@@ -0,0 +1,11 @@
+{
+  "description": "explicit graphql-js development mode should work with node",
+  "private": true,
+  "type": "module",
+  "scripts": {
+    "test": "node bootstrap.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  }
+}

integrationTests/dev-node-explicit/test.js

@@ -0,0 +1,33 @@
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  // If isObjectType did not throw, this line will be reached.
+  throw new Error(
+    'Expected isObjectType to throw an error in Node.js explicit development mode.',
+  );
+} catch (error) {
+  // Case 1: The error is the one we threw from the 'try' block.
+  // This means isObjectType() itself did NOT throw an error.
+  if (
+    error.message ===
+    'Expected isObjectType to throw an error in Node.js explicit development mode.'
+  ) {
+    throw error; // Re-throw this error to indicate the test failure.
+  }
+  // Case 2: isObjectType() itself threw an error. Now check if it's the correct error.
+  else if (!error.message.includes('from another module or realm')) {
+    // If the message does NOT include the expected text, then it's the wrong error.
+    throw new Error(
+      `Expected error message to include 'from another module or realm', but got: "${error.message}"`,
+    );
+  }
+  // If none of the above, it means isObjectType() threw an error, AND that error's message was correct.
+  // So, the test passes by not throwing anything further from the catch block.
+}

integrationTests/dev-node-implicit/package.json

@@ -0,0 +1,11 @@
+{
+  "description": "graphql-js development condition should work with node",
+  "private": true,
+  "type": "module",
+  "scripts": {
+    "test": "node --conditions=development test.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  }
+}

integrationTests/dev-node-implicit/test.js

@@ -0,0 +1,28 @@
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Node.js implicit development mode.',
+  );
+} catch (error) {
+  if (
+    error.message ===
+    'Expected isObjectType to throw an error in Node.js implicit development mode.'
+  ) {
+    throw error;
+  }
+  if (
+    !(error.message.includes('multiple') || error.message.includes('GraphQL'))
+  ) {
+    throw new Error(
+      `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`,
+    );
+  }
+}

integrationTests/dev-rollup/package.json

@@ -0,0 +1,16 @@
+{
+  "description": "graphql-js development condition should work with Rollup",
+  "private": true,
+  "type": "module",
+  "scripts": {
+    "build": "rollup -c",
+    "test": "npm run build && node dist/bundle.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  },
+  "devDependencies": {
+    "rollup": "^4.0.0",
+    "@rollup/plugin-node-resolve": "^15.0.0"
+  }
+}

integrationTests/dev-rollup/rollup.config.js

@@ -0,0 +1,14 @@
+import resolve from '@rollup/plugin-node-resolve';
+
+export default {
+  input: 'src/index.js',
+  output: {
+    file: 'dist/bundle.js',
+    format: 'es'
+  },
+  plugins: [
+    resolve({
+      exportConditions: ['development']
+    })
+  ]
+};

integrationTests/dev-rollup/src/index.js

@@ -0,0 +1,28 @@
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in Rollup development mode.',
+  );
+} catch (error) {
+  if (
+    error.message ===
+    'Expected isObjectType to throw an error in Rollup development mode.'
+  ) {
+    throw error;
+  }
+  if (
+    !(error.message.includes('multiple') || error.message.includes('GraphQL'))
+  ) {
+    throw new Error(
+      `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`,
+    );
+  }
+}

integrationTests/dev-swc/.swcrc

@@ -0,0 +1,12 @@
+{
+  "jsc": {
+    "parser": {
+      "syntax": "ecmascript",
+      "jsx": false
+    },
+    "target": "es2020"
+  },
+  "module": {
+    "type": "es6"
+  }
+}

integrationTests/dev-swc/bootstrap.js

@@ -0,0 +1,3 @@
+// SWC doesn't support conditional exports, so we use explicit development mode
+import 'graphql/dev';
+import './dist/index.js';

integrationTests/dev-swc/package.json

@@ -0,0 +1,16 @@
+{
+  "description": "graphql-js development condition should work with SWC",
+  "private": true,
+  "type": "module",
+  "scripts": {
+    "build": "swc src -d dist",
+    "test": "npm run build && node bootstrap.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  },
+  "devDependencies": {
+    "@swc/cli": "^0.1.0",
+    "@swc/core": "^1.3.0"
+  }
+}

integrationTests/dev-swc/src/index.js

@@ -0,0 +1,28 @@
+import { isObjectType } from 'graphql';
+
+class GraphQLObjectType {
+  get [Symbol.toStringTag]() {
+    return 'GraphQLObjectType';
+  }
+}
+
+try {
+  isObjectType(new GraphQLObjectType());
+  throw new Error(
+    'Expected isObjectType to throw an error in SWC development mode.',
+  );
+} catch (error) {
+  if (
+    error.message ===
+    'Expected isObjectType to throw an error in SWC development mode.'
+  ) {
+    throw error;
+  }
+  if (
+    !(error.message.includes('multiple') || error.message.includes('GraphQL'))
+  ) {
+    throw new Error(
+      `Expected error message to include 'multiple' or 'GraphQL', but got: "${error.message}"`,
+    );
+  }
+}

integrationTests/dev-webpack/package.json

@@ -0,0 +1,14 @@
+{
+  "description": "graphql-js development condition should work with Webpack",
+  "private": true,
+  "scripts": {
+    "test": "webpack --mode=development && node dist/main.js"
+  },
+  "dependencies": {
+    "graphql": "file:../graphql.tgz"
+  },
+  "devDependencies": {
+    "webpack": "^5.0.0",
+    "webpack-cli": "^5.0.0"
+  }
+}