Pick up the docstrings of hybrid properties#344
Merged
erikwrede merged 1 commit intographql-python:masterfrom May 5, 2022
Merged
Pick up the docstrings of hybrid properties#344erikwrede merged 1 commit intographql-python:masterfrom
erikwrede merged 1 commit intographql-python:masterfrom
Conversation
erikwrede
approved these changes
May 4, 2022
Member
erikwrede
left a comment
erikwrede
left a comment
There was a problem hiding this comment.
Looks good, thank you for reopening this!
Contributor
Author
|
You're welcome! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #344 +/- ##
==========================================
+ Coverage 96.38% 96.39% +0.01%
==========================================
Files 9 9
Lines 719 721 +2
==========================================
+ Hits 693 695 +2
Misses 26 26 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@erikwrede, I had deleted my repo, so this is a new PR to replace #298.
The issue that I had with SQA <1.3.19 regarding the ordering of all_orm_descriptors
is resolved by sorting
list(ReporterType._meta.fields.keys()).