Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeus throws objects as errors #387

Open
smcgivern opened this issue Dec 4, 2023 · 0 comments
Open

Zeus throws objects as errors #387

smcgivern opened this issue Dec 4, 2023 · 0 comments

Comments

@smcgivern
Copy link

If a response from the server isn't OK, handleFetchResponse will reject the promise (throwing an error) with the JSON-parsed version of the response:

This seems like it would either be better off as a GraphQLError, or a different type. Throwing an object as an error is a bit confusing for callers (see graphql/graphql-js#1393, for example).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant