Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight mistakes when using makeExtendSchemaPlugin #671

Open
benjie opened this issue Sep 29, 2020 · 0 comments
Open

Highlight mistakes when using makeExtendSchemaPlugin #671

benjie opened this issue Sep 29, 2020 · 0 comments

Comments

@benjie
Copy link
Member

benjie commented Sep 29, 2020

Feature description

Make it more obvious to users of makeExtendSchemaPlugin when they've done something wrong; for example referencing a type that doesn't exist, or using the wrong keyword.

Motivating example

Currently you can write code such as:

extend type DeleteProductionRunInput {
  force: BOOLEAN
}

Or

extend type ThisTypeDoesNotExist {
  foo: String
}

and PostGraphile will process it, queue it up to extend that type when it's defined and thus never actually do anything since the type never is built in the first place. This is due to the way that PostGraphile's hooks work. We should also register a finalize hook that checks that all the rules that were added had at least one match - if not, we should warn aboout that rule.

@benjie benjie added this to V5.0.0 Oct 5, 2023
@github-project-automation github-project-automation bot moved this to 🌳 Triage in V5.0.0 Oct 5, 2023
@benjie benjie moved this from 🌳 Triage to 🐭 Shrew in V5.0.0 Oct 5, 2023
@benjie benjie removed this from V5.0.0 Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant