Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tamedevil needs identifier tracking improvements #485

Open
benjie opened this issue Aug 22, 2023 · 0 comments
Open

tamedevil needs identifier tracking improvements #485

benjie opened this issue Aug 22, 2023 · 0 comments
Labels
Milestone

Comments

@benjie
Copy link
Member

benjie commented Aug 22, 2023

In c16ac7e I broke a naming conflict by prepending a $; but that's not good enough in general. We need tamedevil to track all identifiers and make sure they're always unique. This is the query that caused the issue (running against test database with polymorphic schema):

query Q {
  allRelationalItems(first: 1) {
    nodes {
      id
      type
      relationalItemByParentId {
		id
        type
      }
    }
  }
}

Perhaps we should use symbols like in pg-sql2, where the symbol description is just a hint.

@benjie benjie added this to the V5 RC milestone Aug 22, 2023
@benjie benjie added this to V5.0.0 Oct 4, 2023
@github-project-automation github-project-automation bot moved this to 🌳 Triage in V5.0.0 Oct 4, 2023
@benjie benjie moved this from 🌳 Triage to 🦥 Sloth in V5.0.0 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: 🦥 Sloth
Development

No branches or pull requests

1 participant