Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure all the TypeScript types are valid from both CJS and ESM #482

Open
benjie opened this issue Aug 21, 2023 · 0 comments
Open

Make sure all the TypeScript types are valid from both CJS and ESM #482

benjie opened this issue Aug 21, 2023 · 0 comments
Labels
🙏 help-wanted 🔬 research
Milestone
V5 RC

Comments

@benjie
Copy link
Member

benjie commented Aug 21, 2023

https://arethetypeswrong.github.io/?p=postgraphile%405.0.0-beta.6

ref https://blog.isquaredsoftware.com/2023/08/esm-modernization-lessons/

CJS default export
CommonJS module simulates a default export with exports.default and exports.__esModule, but does not also set module.exports for compatibility with Node. Node, and some bundlers under certain conditions, do not respect the __esModule marker, so accessing the intended default export will require a .default property access on the default import.
@benjie benjie added this to the V5 RC milestone Aug 21, 2023
@benjie benjie added this to V5.0.0 Oct 4, 2023
@github-project-automation github-project-automation bot moved this to 🌳 Triage in V5.0.0 Oct 4, 2023
@benjie benjie moved this from 🌳 Triage to 🐭 Shrew in V5.0.0 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🙏 help-wanted 🔬 research
Projects
V5.0.0
Status: 🐭 Shrew
Milestone
V5 RC
Development

No branches or pull requests
1 participant
@benjie