Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EXPLAIN #388

Open
benjie opened this issue Jun 23, 2023 · 2 comments
Open

Fix EXPLAIN #388

benjie opened this issue Jun 23, 2023 · 2 comments
Milestone

Comments

@benjie
Copy link
Member

benjie commented Jun 23, 2023

  1. Currently EXPLAIN ANALYZE can only be used on SELECT statements. This isn't quite right since a volatile function can be called from a SELECT statement - explain analyze should only be available on non-mutation SQL queries.
  2. Currently you have to set an environmental variable to see explain in GraphiQL. This should instead be controlled by a header (and a config option). And there should be separate configs for EXPLAIN and EXPLAIN ANALYZE
  3. It should be easy to copy your query plan into a cost analysis tool such as https://explain.depesz.com/ or https://explain.dalibo.com/
  4. It should be easy to copy the SQL and potentially even embed the variable values so the user can debug.
  5. Rather than sending mermaid diagrams over the wire, the system should generate a JSON representation of the plan and the mermaid diagram (or alternative!) should be generated on the client
@benjie benjie added this to the V5 RC milestone Jun 23, 2023
@jemgillam
Copy link
Collaborator

If we don't do this before release, we need to make it clear that the data format is not stable.

@jemgillam
Copy link
Collaborator

cf #413

@benjie benjie added this to V5.0.0 Oct 4, 2023
@github-project-automation github-project-automation bot moved this to 🌳 Triage in V5.0.0 Oct 4, 2023
@benjie benjie moved this from 🌳 Triage to 🦥 Sloth in V5.0.0 Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🦥 Sloth
Development

No branches or pull requests

2 participants