Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customizable line properties of suggested routes #334

Open
apophenic-treehugger opened this issue Apr 22, 2023 · 9 comments
Open

Customizable line properties of suggested routes #334

apophenic-treehugger opened this issue Apr 22, 2023 · 9 comments
Labels
feature request Requests for new features that won't necessarily be realized

Comments

@apophenic-treehugger
Copy link

I suggest a visual improvement to the online routing interface.

Problem
When using the newly introduced cyclosm layer in the online router (#317 ), there are two related problems:

  • It can be difficult to distinguish the route suggested by graphhopper from the blue cycle infrastructure of the basemap.
  • The suggested route obscures valuable information of the basemap below ("Is the thing below the route a cycle path or a road?")

Example
Here it is hard or impossible to tell whether the route leads along a cycle track or a road.

Suggested solution
Add a few simple slidebar controls to set the line properties:

  • colour
  • transparency
  • width
  • style (solid, dashed, dotted)

The user can then change them as they deem fit.

Additionally to my suggestion, it may make sense to already set the defaults to different values when cyclosm is used as baselayer.

@ratrun
Copy link
Contributor

ratrun commented Apr 22, 2023

A probably simpler solution is to define a key with which it is possible to hide the route as long as the key is pressed. Komoot uses the `m' key for this.

@karussell
Copy link
Member

karussell commented Apr 22, 2023

We'll not introduce a control for this but I like your idea @ratrun with the m key as it is a simple and effective solution! (and what does m mean? "mute" the route layer :) ?)

@apophenic-treehugger
Copy link
Author

m like moooooooore basemap!

@easbar
Copy link
Member

easbar commented Apr 23, 2023

If someone has a suggestion how to improve the current color/style/width we could also change it instead of adding controls.

@apophenic-treehugger
Copy link
Author

I think it's good if the line is dashed.

How about a thin dashed yellow line (somewhere around #fff176) with a semi-transparent black halo (#000000a0 or so) ?

@karussell
Copy link
Member

A dashed line cannot be used. We already use this to show where the markers snap (#327). Furthermore IMO it would look strange.

dashed yellow line (somewhere around #fff176)

IMO it should be consistent with the color scheme we already use. And yellow does not make a good color for the route as this would be sometimes too light.

btw: we are already using a slightly transparent blue but probably this is not necessary when we let the route disappear with the 'm' key. Because transparent also means it easily disappears on the colorful map. All the maps services I just tried use no transparent color for the route. Komoot even uses a white border of the route line to highlight it further.

@apophenic-treehugger
Copy link
Author

So what do you propose?

@karussell
Copy link
Member

karussell commented Apr 24, 2023

I still like the idea from @ratrun :)

IMO we cannot improve the colors etc in a manner that the road underneath is easily visible and the route does not visually "disappear", but I'm open for other suggestions.

@apophenic-treehugger
Copy link
Author

I'm fine with whatever solution that solves the problem. Obviously, there are various ways to do this. I've tried to make constructive suggestions and they were rejected. I don't feel like I have the authority to decide this, nor do I have the skills to implement any of the solutions discussed.

@karussell karussell added the feature request Requests for new features that won't necessarily be realized label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Requests for new features that won't necessarily be realized
Projects
None yet
Development

No branches or pull requests

4 participants