Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ipu specialised implementations of special functions used in experimental.integrals #93

Open
hatemhelal opened this issue Sep 19, 2023 · 2 comments

Comments

@hatemhelal
Copy link
Contributor

hatemhelal commented Sep 19, 2023

The following special functions are used in the evaluation of electron integrals following the THO methods:

  • factorial: could we just use the scipy impl? Not available in the v0.3 JAX that we are pinned to.
  • factorial2: similar, to above: would prefer to use the scipy implementation.
  • binom: same
@AlexanderMath
Copy link
Contributor

AlexanderMath commented Sep 21, 2023

Could you add a list of the needed functions? Assuming they are things like erfc and inv_gamma etc. Do you suspect we'll have to implement them in C?

@hatemhelal
Copy link
Contributor Author

I think some of the issues might go away by upgrading to 0.4 JAX (or at least there will probably be new issues). I think there should be some cmath functions that could be used at least for the gamma evaluation within the vertex but would need to be tested.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants