Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awkward KZGSettings::new() API #264

Open
nazar-pc opened this issue Sep 4, 2024 · 0 comments
Open

Awkward KZGSettings::new() API #264

nazar-pc opened this issue Sep 4, 2024 · 0 comments

Comments

@nazar-pc
Copy link
Contributor

nazar-pc commented Sep 4, 2024

I was upgrading from much older version and noticed that KZGSettings::new() is not really idiomatic Rust.

Specifically for FsKZGSettings it ignored one of the arguments, for 3 other arguments it does memory allocation (with .to_vec() and .clone()) instead of taking owned vectors as arguments directly.

On a similar note FsKZGSettings now has precomputation field that is public and can be set to anything, also for some reason it has Arc in it. Is it really supposed to be set publicly to arbitrary value? If not then it should probably not be public. I only write this because previously I was constructing FsKZGSettings directly and now it that I should be using FsKZGSettings::new() instead to fill precomputation correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant