Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fr FFT doesn't really use all the cores fully #227

Open
nazar-pc opened this issue May 2, 2023 · 0 comments
Open

Fr FFT doesn't really use all the cores fully #227

nazar-pc opened this issue May 2, 2023 · 0 comments

Comments

@nazar-pc
Copy link
Contributor

nazar-pc commented May 2, 2023

I was not able to find the culprit, but on my machine (24C/32T 13900K) switching from single-threaded to parallel FFT uses multiple CPU cores, but only slightly, resulting in ~3x time reduction, likely with a lot of wasted compute in the process.

It would have been nice to leverage CPU cores fully. There is already short-circuiting for parallelism when number of elements on each side is below 256:
https://github.com/sifraitech/rust-kzg/blob/5655cdd039788b1df4d628036fdc705080e000eb/blst-from-scratch/src/fft_fr.rs#L40

Tweaking it either way worsened time for me though.

I think there must be an opportunity for further performance or at very least efficiency improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant