Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Securtity risk on "success" #8

Open
pabloalba opened this issue Feb 10, 2014 · 0 comments
Open

Securtity risk on "success" #8

pabloalba opened this issue Feb 10, 2014 · 0 comments

Comments

@pabloalba
Copy link

The "success" method is called as a callback when the payment at paypal is finished. But there is no guarantee that the payment has been really done. An user could call himself to the success url, and the controller will mark the payment as COMPLETE.

I think that is a high security risk. The only one that should mark a payment as complete is the IPN notification, once it has verified the notification with paypal.

I will submit later a pull request fixing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant