-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links to logs from a span #94
Comments
Just adding this to the data sources board, to ensure we keep track of it, but it sounds like the plan is for @aocenas to finish this up once he has the log group info he needs. Let me know if you want a code review or anything! |
@sarahzinger is this waiting for something or can it be moved to the backlog? |
I suppose we can move it to the backlog, I'm still working on getting the right test app set up to properly test this. |
Just an update on this: I looked at this, was able to create better test trace data with corresponding log groups and I don't think this will work for anything other than Lambdas as we don't really have a way to know the log group name for services besides lambdas. We thought ECS and EKS would follow a similar pattern, but it seems that log group names are case sensitive, which at least in the test app we created it seems that the service names passed in subsegments often are all lowercase, even if the service name is case-sensitive. I think we have a few possibilities here:
Will discuss with the AWS team to see if they also have ideas we may have not considered. |
I think the "Span to Logs link" should support data source selection (Loki, CloudWatch Logs or external links, similar as Derived fields in Loki data source configuration). |
closing as stale |
Add link to logs, based on configured linked ClouWatch data source. Similar to linking between Tempo and Loki
The text was updated successfully, but these errors were encountered: