Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Have better internal error types #66

Open
iainlane opened this issue Jul 14, 2023 · 0 comments
Open

Have better internal error types #66

iainlane opened this issue Jul 14, 2023 · 0 comments
Labels
good-first-issue Good issue for new contributors to the project: not too simple, and would have decent impact

Comments

@iainlane
Copy link
Member

What we do at the minute is mainly use fmt.Errof to add a bit of context to our errors. We could be a bit better about that, and add our own error types.

Likely we could use those to print better error messages, but the main benefit would be in the testsuite we could check the error returned to see if the condition we wanted has happened - currently we check it in a pretty naive way.
@iainlane iainlane added the good-first-issue Good issue for new contributors to the project: not too simple, and would have decent impact label Jul 14, 2023
@iainlane iainlane mentioned this issue Jul 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good issue for new contributors to the project: not too simple, and would have decent impact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@iainlane