Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CheckResponse on replies from the GitHub API #23

Open
iainlane opened this issue Mar 27, 2023 · 0 comments
Open

Use CheckResponse on replies from the GitHub API #23

iainlane opened this issue Mar 27, 2023 · 0 comments

Comments

@iainlane
Copy link
Member

          Suggestion, maybe something to consider for a follow-up (as it could apply to multiple locations in the codebase). Using `github.CheckResponse(...)` to validate the response for errors (check things like unauthorised, rate-limited, etc.)
	checkRuns, resp, err := c.client.Checks.ListCheckRunsForRef(ctx, owner, repoName, ref, opt)
	if err := github.CheckResponse(resp.Response); err != nil {
		// process the error(s)
	}

Originally posted by @jvrplmlmn in #21 (comment)

Here are the docs for this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant