Implement terraform Resource methods on resourceMetricsEndpointScrapeJob #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
Base automatically changed from
shirley/connections-api-client
to
metrics-endpoint
September 24, 2024 16:12
fridgepoet
force-pushed
the
shirley/terraform-resource-methods
branch
from
4fffc5a
to
43a37f0
Compare
fridgepoet
force-pushed
the
shirley/terraform-resource-methods
branch
from
6fde641
to
a70d7b0
Compare
…erraform-resource-methods
fridgepoet
commented
Oct 11, 2024
| @@ -27,9 +27,6 @@ const ( | |||
|
|
|||
| func NewClient(authToken string, rawURL string, client *http.Client) (*Client, error) { | |||
| parsedURL, err := url.Parse(rawURL) | |||
| if parsedURL.Scheme != "https" { | |||
There was a problem hiding this comment.
Removing this check in order to mock with normal httptest server in acceptance tests.
|
The failing acceptance tests/cloudinstance seems to be from OnCall tests.. https://github.com/grafana/terraform-provider-grafana/actions/runs/11295196530/job/31417373511?pr=1812 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the methods for a terraform Resource on resourceMetricsEndpointScrapeJob.
Contributes to https://github.com/grafana/cloud-onboarding/issues/7670.