Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App plugin: Update to react-router v6 #713

Open
3 of 7 tasks
leventebalogh opened this issue Mar 7, 2024 · 6 comments
Open
3 of 7 tasks

App plugin: Update to react-router v6 #713

leventebalogh opened this issue Mar 7, 2024 · 6 comments
Assignees
Labels
dependencies frontend Needs to be implemented in the frontend application

Comments

@leventebalogh
Copy link
Contributor

leventebalogh commented Mar 7, 2024

Starting from Grafana 10, plugins can start using the v6 of react-router. Overall, react-router v6 aims to simplify route configuration and provide a more flexible and intuitive API for developers.

Why?

We are going to deprecate using react-router v5 in plugins from Grafana 11, and we would like to make sure our internal app plugins are using the v6 version by the time we finish migrating Grafana core itself.

How?

We have created a migration guide for plugins (please see the links below), and also don't hesitate to reach out in #grafana-plugins-platform in Slack in case you have any questions.

@The-9880
Copy link

FYI @rdubrock it looks like there aren't any deadlines for this yet (ref) so I backlogged it - feel free to pull into a cycle at your discretion!

@rdubrock
Copy link
Contributor

Doing this depends on scenes also moving to v6 => grafana/scenes#608

@ckbedwell ckbedwell added the frontend Needs to be implemented in the frontend application label May 1, 2024
@peterschretlen
Copy link
Contributor

@grafanaman has done some of this work, but have not yet jumped to v6.

@peterschretlen
Copy link
Contributor

I think we are still waiting on grafana/scenes#608 before we do the update.

@w1kman
Copy link
Contributor

w1kman commented Dec 16, 2024

@grafanaman has done some of this work, but have not yet jumped to v6.

We're using react-router-dom-v5-compat, the migration work for v6 has been done because we have no dependencies on v5 (except for some tests).

I think we are still waiting on grafana/scenes#608 before we do the update.

When this is merged, we could officially bundle with v6 (which technically is react-router-dom-v5-compat).

@w1kman w1kman self-assigned this Dec 16, 2024
@w1kman
Copy link
Contributor

w1kman commented Dec 16, 2024

I've updated the issue description to reflect what has been done and that we're waiting for grafana/scenes#608 to be merged before we do anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies frontend Needs to be implemented in the frontend application
Projects
None yet
Development

No branches or pull requests

6 participants