SceneAppPage: preserving tabs #567
Open
+42
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xforman2
changed the title
torkelo
reviewed
Feb 5, 2024
|
I do not want to change the default route, I just try to change what will be rendered. So I just reused the old logic:
And now:
Hope that makes it more clear. |
|
that seems a bit wrong that different pages are rendered for the same url |
|
I agree that it is not good to have different pages render with the same url, so I tried what you suggested in the first answer. What do you think? |
|
@torkelo I am not sure if you looked at my other implementation but it would be really helpful if this could get resolved |
|
I have, the solution looks a bit complex / messy. Should be a simpler way to do this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So after discovering #559, I thought it would be nice to have a option to preserve the tabs.
I came up with an idea.
Now the SceneAppPageRenderer always renders the first tab with two urls: the parent page url and the actual tab url.
But if we can remember the last selected tab, we can match the parent page url to any tab. This is what
_lastTabIndexis for.And you also have an option to choose not preserving tabs with
preserveTabproperty.Let me know what you think.