Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AdHocFiltersCombobox: Collapse filters to save space #962

Open
Sergej-Vlasov opened this issue Nov 8, 2024 · 1 comment
Open

AdHocFiltersCombobox: Collapse filters to save space #962

Sergej-Vlasov opened this issue Nov 8, 2024 · 1 comment
Assignees
Labels
area/variables Issues related to variables system in scenes

Comments

@Sergej-Vlasov
Copy link
Contributor

The main idea here is to hide filters when we have many filters defined to save on space in the dashboard.

Issues:

  1. Filter variable will grow until it takes up the whole line and wrap line only after its fully grown
    • this makes it tricky to determine when exactly to collapse when we have another variable in the same line:
      Image
  2. Mechanism to uncollapse filters
    • some users might prefer to have filters uncollapsed all the time
      • how do we offer that? - add variable setting to collapse/keep uncollapsed?

Current POC PR with some guess work on when and how to collapse.
Demo from POC PR:

Screen.Recording.2024-11-08.at.11.24.49.mov
@Sergej-Vlasov Sergej-Vlasov added the area/variables Issues related to variables system in scenes label Nov 8, 2024
@Sergej-Vlasov
Copy link
Contributor Author

@Ijin08 @dprokop encountered few tricky issues that I feel need discussion, so saving my work here until we can sync online/offline regarding this.

@Sergej-Vlasov Sergej-Vlasov changed the title AdHocFiltersCombobox: Collapse filters when to save space AdHocFiltersCombobox: Collapse filters to save space Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/variables Issues related to variables system in scenes
Projects
None yet
Development

No branches or pull requests

3 participants