Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Helm using the -config.file but hosted in the values.yaml #3790

Open
mbrancato opened this issue Dec 17, 2024 · 0 comments
Open

Support Helm using the -config.file but hosted in the values.yaml #3790

mbrancato opened this issue Dec 17, 2024 · 0 comments

Comments

@mbrancato
Copy link

Is your feature request related to a problem? Please describe.

It is extremely confusing what config is relevant in the Helm chart today.

The config in the Helm chart today is for a dependency "Phlare", and can seem like it is part of the Pyroscope configuration.

structuredConfig: {}
# -- Contains Phlare's configuration as a string.
# @default -- The config depends on other values been set, details can be found in [`values.yaml`](./values.yaml)
config: |
{{- if .Values.minio.enabled }}
storage:
backend: s3
s3:
endpoint: "{{ include "pyroscope.fullname" . }}-minio:9000"
bucket_name: {{(index .Values.minio.buckets 0).name | quote }}
access_key_id: {{ .Values.minio.rootUser | quote }}
secret_access_key: {{ .Values.minio.rootPassword | quote }}
insecure: true
{{- end }}

But when you look closer, this is not the Pyroscope configuration file. The example uses:

storage:
  backend: s3
  s3:
    endpoint: "minio:9000"

But Pyroscope uses:

s3_storage_backend:
  endpoint: "minio:9000"

This means that most of the available configuration parameters are left to be specified in the extraArgs section as CLI params.

Describe the solution you'd like

There should be a structured Pyroscope configuration that aligns with the Pyroscope documentation in the Helm chart values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant