Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align /ingest HTTP API validation with Push API #3721

Open
kolesnikovae opened this issue Nov 26, 2024 · 1 comment · Fixed by #3722
Open

Align /ingest HTTP API validation with Push API #3721

kolesnikovae opened this issue Nov 26, 2024 · 1 comment · Fixed by #3722
Assignees
@marcsanmi
Labels
type/bug Something isn't working

Comments

@kolesnikovae
Copy link
Collaborator

The /ingest HTTP API has a long history and imposes stricter requirements on the service_name label (previously referred to as the "app name" in pre-v1 versions). Specifically, in the Push API, service_name supports UTF-8, whereas in the /ingest HTTP API, the allowed character set is more restricted (e.g., it does not permit / in the service name).
@kolesnikovae kolesnikovae added the type/bug Something isn't working label Nov 26, 2024
@marcsanmi marcsanmi self-assigned this Nov 26, 2024
@kolesnikovae
Copy link
Collaborator Author

Related: grafana/alloy#2158

@marcsanmi marcsanmi mentioned this issue Nov 27, 2024
Merged
@kolesnikovae kolesnikovae reopened this Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcsanmi marcsanmi

Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(flameql): allow slashes in tag name grafana/pyroscope
2 participants
@marcsanmi @kolesnikovae