Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an ability to not start the agent on some instances #154

Open
SHaaD94 opened this issue Jun 19, 2024 · 0 comments
Open

Add an ability to not start the agent on some instances #154

SHaaD94 opened this issue Jun 19, 2024 · 0 comments

Comments

@SHaaD94
Copy link

SHaaD94 commented Jun 19, 2024

We are currently integrating the Pyroscope Java agent into our infrastructure, and it works great. However, we have encountered a problem: In cases of a large fleet of pods (1000+) and aggressive sampling, we generate too much profiling data for the server to handle. Additionally, the 2-3% profiling overhead becomes a significant resource drain.

I propose adding an option (both in the SDK and as an environment variable) named PYROSCOPE_CLUSTER_RATIO with a value in percentage (0-100). This feature would enable the agent only if a randomly generated value in an inclusive range 0-100 is less than the provided percentage.

This feature will allow users to save resources on both the server and client sides while still maintaining statistically viable continuous profiling data for large deployments.

I would be glad to help implement this feature if you consider it appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant