Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Past users still showing in schedules #4936

Closed
matiasb opened this issue Aug 27, 2024 · 0 comments
Closed

Past users still showing in schedules #4936

matiasb opened this issue Aug 27, 2024 · 0 comments
Assignees
@matiasb
Labels
bug Something isn't working papercut part:schedules

Comments

@matiasb
Copy link
Contributor

matiasb commented Aug 27, 2024

What went wrong?

What happened:

  • A user that has been removed from a schedule is still shown in the schedule details page, and may still get notifications about shift swaps.

What did you expect to happen:

  • Once a user has no scheduled shifts in the future should be not considered part of the schedule.

How do we reproduce it?

Create a schedule with a rotation including a few users. Remove a user (that had been assigned an on-call in the past) from the rotation, save as new rotation. Alternatively, create an override setting up a new user to be on-call (not involved in any rotation). That user will be associated to the schedule since then.

Grafana OnCall Version

r411-v1.9.16

Product Area

Schedules

Grafana OnCall Platform?

None

User's Browser?

No response

Anything else to add?

No response
@matiasb matiasb added the bug Something isn't working label Aug 27, 2024
@ravishankar15 ravishankar15 mentioned this issue Sep 21, 2024
Closed
3 tasks
@matiasb matiasb mentioned this issue Sep 30, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 1, 2024
@matiasb
Update schedule related users to use cached final representation (#5101)
8754f60 
Related to #4936

Cached final schedule keeps a (now - 15d, now + 6m) window
representation of a schedule (this representation always use users'
username; it will un-relate users that are not anymore associated to a
schedule).
@matiasb matiasb closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matiasb matiasb

Labels
bug Something isn't working papercut part:schedules
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@matiasb @joeyorlando @raphael-batte