Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

App plugin: Update to react-router v6 #4031

Closed
leventebalogh opened this issue Mar 7, 2024 · 3 comments · Fixed by #4703
Closed

App plugin: Update to react-router v6 #4031

leventebalogh opened this issue Mar 7, 2024 · 3 comments · Fixed by #4703
Assignees
@teodosii
Labels
involved:Frontend

Comments

@leventebalogh
Copy link
Contributor

Starting from Grafana 10, plugins can start using the v6 of react-router. Overall, react-router v6 aims to simplify route configuration and provide a more flexible and intuitive API for developers.

Why?

We are going to deprecate using react-router v5 in plugins from Grafana 11, and we would like to make sure our internal app plugins are using the v6 version by the time we finish migrating Grafana core itself.

How?

We have created a migration guide for plugins (please see the links below), and also don't hesitate to reach out in #grafana-plugins-platform in Slack in case you have any questions.
@joeyorlando
Copy link
Contributor

added this to "To Be Groomed" because it appears we are currently using a deprecated version of react router (Grafana 11 has been out for ~2 months as of the writing of this comment)

@teodosii teodosii self-assigned this Jul 8, 2024
@teodosii
Copy link
Member

Blocked until grafana/scenes#608 is sorted out - Right now all other pages in OnCall work with v6, except for Insights which uses scenes

@teodosii teodosii mentioned this issue Jul 19, 2024
Merged
@teodosii
Copy link
Member

Opened a PR #4703 for it - it changes OnCall so that we rely on the react-router-compat version but its using v6 syntax. Can't fully migrate to v6 as grafana/scenes still relies on v5 and that seems to break rendering on the Insights page

github-merge-queue bot pushed a commit that referenced this issue Jul 26, 2024
@teodosii
Migrate react-router to v6 (#4703)
0aa3b1d 
# What this PR does

- Migrate react-router from v5 to v6

Closes #4031
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teodosii teodosii

Labels
involved:Frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate react-router to v6 grafana/oncall
4 participants
@iskhakov @joeyorlando @leventebalogh @teodosii