Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvstore (of e.g. distributor ha_tracker) in redis/valkey #9002

Closed
genofire opened this issue Aug 14, 2024 · 2 comments
Closed

kvstore (of e.g. distributor ha_tracker) in redis/valkey #9002

genofire opened this issue Aug 14, 2024 · 2 comments

Comments

@genofire
Copy link

genofire commented Aug 14, 2024

Is your feature request related to a problem? Please describe.

To support beside etcd and consul also redis/valkey kvstores

Describe the solution you'd like

redis/valkey is also a really common tool for keyvalue storage (and cacheing)

Additional context

an example how the configuration could look like

limits:
  accept_ha_samples: true
  ha_cluster_label: "env_id"
  ha_replica_label: "prometheus_replica"

distributor:
  ha_tracker:
    enable_ha_tracker: true
    ha_tracker_update_timeout: 15s
    ha_tracker_update_timeout_jitter_max: 5s
    ha_tracker_failover_timeout: 30s
  kvstore:
    store: redis
redis:
  endpoint: "valkey.mimir.svc"
@dimitarvdimitrov
Copy link
Contributor

looks related to #1597. Would using memberlist instead also work in your setup?

@56quarters
Copy link
Contributor

To add to the above: there are no plans to expand our use of Redis to HA tracker and it's extremely unlikely we'd add this or accept a community PR that added this. Hopefully the linked issue of using memberlist would fit your use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants