Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UTF-8 character support for label and metric names #10283

Open
tinitiuset opened this issue Dec 19, 2024 · 1 comment
Open

UTF-8 character support for label and metric names #10283

tinitiuset opened this issue Dec 19, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@tinitiuset
Copy link
Contributor

Prometheus supports this as of 3.0 but Mimir does not support it still.

If UTF-8 is enabled, some tests will need work:

  • TestLabelValuesCardinalityHandler_ParseError
  • ...

UTF-8 is specifically disabled in different places by setting model.NameValidationScheme = model.LegacyValidation in init functions.

Related issues:
@tinitiuset tinitiuset added the enhancement New feature or request label Dec 19, 2024
@tinitiuset tinitiuset mentioned this issue Dec 19, 2024
Merged
4 tasks
@ywwg
Copy link
Member

ywwg commented Dec 19, 2024

another somewhat prerequisite is the work in grafana -- we shouldn't turn on utf8 until that is in: grafana/grafana#96244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ywwg @tinitiuset