-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider working with CRI-O to deal with byte streams from containers rather than scraping logs from files #231
Labels
component/agent
component/integrations
keepalive
An issue or PR that will be kept alive and never marked as stale.
type/feature
Something new we should do
Comments
Closed
cc @brancz |
This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
We are still interested @Stale . |
stale
bot
removed
the
stale
A stale issue or PR that will automatically be closed.
label
Sep 4, 2019
cyriltovena
added
keepalive
An issue or PR that will be kept alive and never marked as stale.
component/agent
component/integrations
type/feature
Something new we should do
labels
Sep 4, 2019
jeschkies
added a commit
to jeschkies/loki
that referenced
this issue
Feb 28, 2022
Summary: - Introduces Queries interface with HTTP handlers. - Configures a multi-tenant querier that just passes requests through. - Closes grafana#231
jeschkies
added a commit
that referenced
this issue
Mar 1, 2022
**What this PR does / why we need it**: - Introduce Queries interface and Querier API. - Configure a multi-tenant querier that just passes requests through. **Which issue(s) this PR fixes**: Closes #231 **Special notes for your reviewer**: **Checklist** - [x] Documentation added - [ ] Tests updated - [ ] Add an entry in the `CHANGELOG.md` about the changes.
Typo in the ticket number. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component/agent
component/integrations
keepalive
An issue or PR that will be kept alive and never marked as stale.
type/feature
Something new we should do
Please consider a path laid out with containers/conmon#265.
Instead of scraping logs from disk, work with CRI-O to get a byte stream (no newline interpretation) of the container output chunked through to the storage system.
Then apply what ever interpretation of the logs one wants later when consuming the data from the store. This avoids all the problems of scraping logs from disk, while efficiently working with the container subsystems to get the container output collected with the right metadata attached.
It also means we can focus on collection with proper metadata efficiently without worry for what interpretation of the container output stream will be applied later. That is, views of the log data can be considered isolated and independent from how the data is collected.
The text was updated successfully, but these errors were encountered: