Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider working with CRI-O to deal with byte streams from containers rather than scraping logs from files #231

Open
portante opened this issue Jan 19, 2019 · 5 comments
Labels
component/agent component/integrations keepalive An issue or PR that will be kept alive and never marked as stale. type/feature Something new we should do

Comments

@portante
Copy link

portante commented Jan 19, 2019

Please consider a path laid out with containers/conmon#265.

Instead of scraping logs from disk, work with CRI-O to get a byte stream (no newline interpretation) of the container output chunked through to the storage system.

Then apply what ever interpretation of the logs one wants later when consuming the data from the store. This avoids all the problems of scraping logs from disk, while efficiently working with the container subsystems to get the container output collected with the right metadata attached.

It also means we can focus on collection with proper metadata efficiently without worry for what interpretation of the container output stream will be applied later. That is, views of the log data can be considered isolated and independent from how the data is collected.

@richm
Copy link

richm commented Jan 19, 2019

@jcantrill @ewolinetz

@jcantrill
Copy link
Contributor

jcantrill commented Feb 1, 2019

cc @brancz

@stale
Copy link

stale bot commented Sep 3, 2019

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Sep 3, 2019
@brancz
Copy link

brancz commented Sep 4, 2019

We are still interested @Stale .

@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Sep 4, 2019
@cyriltovena cyriltovena added keepalive An issue or PR that will be kept alive and never marked as stale. component/agent component/integrations type/feature Something new we should do labels Sep 4, 2019
jeschkies added a commit to jeschkies/loki that referenced this issue Feb 28, 2022
Summary:
- Introduces Queries interface with HTTP handlers.
- Configures a multi-tenant querier that just passes requests through.
- Closes grafana#231
jeschkies added a commit that referenced this issue Mar 1, 2022
**What this PR does / why we need it**:
- Introduce Queries interface and Querier API.
- Configure a multi-tenant querier that just passes requests through.

**Which issue(s) this PR fixes**:
Closes #231

**Special notes for your reviewer**:

**Checklist**
- [x] Documentation added
- [ ] Tests updated
- [ ] Add an entry in the `CHANGELOG.md` about the changes.
@jeschkies
Copy link
Contributor

Typo in the ticket number.

@jeschkies jeschkies reopened this Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/agent component/integrations keepalive An issue or PR that will be kept alive and never marked as stale. type/feature Something new we should do
Projects
None yet
Development

No branches or pull requests

6 participants