-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Labels
Description
Describe the bug
With helm-loki-6.45.1, on rendering the helm chart with:
$ helm template loki loki \
--repo https://grafana.github.io/helm-charts \
--version 6.45.1
Error: execution error at (loki/templates/write/statefulset-write.yaml:50:28): Please define loki.storage.bucketNames.chunks
$ helm template loki loki \
--repo https://grafana.github.io/helm-charts \
--version 6.45.1 \
--set loki.storage.type=filesystem
Error: execution error at (loki/templates/validate.yaml:19:4): Cannot run scalable targets (backend, read, write) or distributed targets without an object storage backend.
I am assuming this is due to this MR.
From my understanding it does not take in consideration that loki.storage.type might not be s3.
Expected behavior
Helm chart is not erroring when using storage of type filesystem.
Environment:
- Infrastructure: Kubernetes,
- Deployment tool: helm
erjan1234, tomposer, Boemeltrein, mathbruyen, jlaska and 18 more