Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider CGO option when calculating binary hash #37

Open
pablochacin opened this issue Sep 18, 2024 · 1 comment
Open

Consider CGO option when calculating binary hash #37

pablochacin opened this issue Sep 18, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@pablochacin
Copy link
Collaborator

The build service cache is insensitive to CGO_ENABLED changes. It can be reproduced if we set CGO_ENABLED to 0 and then build, then set it to 1 and build again. Returns the previously built binary from the cache.

@pablochacin pablochacin added the enhancement New feature or request label Sep 18, 2024
@pablochacin
Copy link
Collaborator Author

The main issue for addressing this information is not available when calculating the hash to use it as a key to check the cache.

The CGO_ENABLED flag is set in the k6foundry's builder, but it's not currently exposed.

If the builder exposed it, the build service could consider it as part of the hash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant