Refactor new command
#4153
Open
Refactor new command
#4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel González Lopes <[email protected]>
Signed-off-by: Daniel González Lopes <[email protected]>
Signed-off-by: Daniel González Lopes <[email protected]>
Signed-off-by: Daniel González Lopes <[email protected]>
|
Happy to fix the linter things if we feel this approach makes sense 👍 |
Signed-off-by: Daniel González Lopes <[email protected]>
Signed-off-by: Daniel González Lopes <[email protected]>
dgzlopes
commented
Jan 3, 2025
Signed-off-by: Daniel González Lopes <[email protected]>
Signed-off-by: Daniel González Lopes <[email protected]>
Signed-off-by: Daniel González Lopes <[email protected]>
Signed-off-by: Daniel González Lopes <[email protected]>
dgzlopes
requested review from
oleiade and
joanlopez
and removed request for
a team
oleiade
approved these changes
Jan 7, 2025
| # Create a minimal k6 script in the current directory. By default, k6 creates script.js. | ||
| {{.}} new | ||
| exampleText := getExampleText(c.gs, ` | ||
| # Create a minimal k6 script |
There was a problem hiding this comment.
I've noticed that both k6 new and k6 new --template minimal work, and it looks like it generates the same script file. As a result I would keep documenting an example of the default behavior of k6 new here 🙇🏻
Also as we're at it, it wasn't immediatly obvious to me that the k6 new command supports a file argument (not flag) from the examples, we might want to also add one demonstrating that?
| } | ||
| } | ||
|
|
||
| export default async function() { |
There was a problem hiding this comment.
This is really a nitpick, and a personal preference, but I would find the code more readable with actual newlines 😄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Early draft PR. Issue with more context: #4154
What?
Why?
Checklist
make lint) and all checks pass.make tests) and all tests pass.Related PR(s)/Issue(s)