From 5c779330ba44165e259ff1c35240fc258b94d1da Mon Sep 17 00:00:00 2001 From: Stavros Foteinopoulos Date: Mon, 20 Jan 2025 18:11:10 +0200 Subject: [PATCH 1/3] workflows: update helm-docs Signed-off-by: Stavros Foteinopoulos --- .github/workflows/linter.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/linter.yml b/.github/workflows/linter.yml index 7534269626..125d171f32 100644 --- a/.github/workflows/linter.yml +++ b/.github/workflows/linter.yml @@ -22,7 +22,7 @@ jobs: - name: Check Docs run: | - docker run --rm --volume "$(pwd):/helm-docs" -u "$(id -u)" jnorwood/helm-docs:v1.8.1 + docker run --rm --volume "$(pwd):/helm-docs" -u "$(id -u)" jnorwood/helm-docs:v1.14.2 if ! git diff --exit-code; then echo "Documentation not up to date. Please run helm-docs and commit changes!" >&2 exit 1 From 429fbaaace8040096256ae1a883dc0b4a8bd0f7a Mon Sep 17 00:00:00 2001 From: Stavros Foteinopoulos Date: Wed, 22 Jan 2025 07:48:27 +0200 Subject: [PATCH 2/3] try to fix docs Signed-off-by: Stavros Foteinopoulos --- charts/loki-distributed/README.md | 4 ++-- charts/loki-distributed/values.yaml | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/charts/loki-distributed/README.md b/charts/loki-distributed/README.md index 8ca6f9552f..7018b86bff 100644 --- a/charts/loki-distributed/README.md +++ b/charts/loki-distributed/README.md @@ -114,7 +114,7 @@ kubectl delete statefulset RELEASE_NAME-loki-distributed-querier -n LOKI_NAMESPA | compactor.livenessProbe | object | `{}` | liveness probe settings for ingester pods. If empty use `loki.livenessProbe` | | compactor.nodeSelector | object | `{}` | Node selector for compactor pods | | compactor.persistence.annotations | object | `{}` | Annotations for compactor PVCs | -| compactor.persistence.claims | list | `[{"name":"data","size":"10Gi","storageClass":null}]` | List of the compactor PVCs @notationType -- list | +| compactor.persistence.claims | list | `[{"name":"data","size":"10Gi","storageClass":null}]` | List of the compactor PVCs | | compactor.persistence.enableStatefulSetAutoDeletePVC | bool | `false` | Enable StatefulSetAutoDeletePVC feature | | compactor.persistence.enabled | bool | `false` | Enable creating PVCs for the compactor | | compactor.persistence.size | string | `"10Gi"` | Size of persistent disk | @@ -307,7 +307,7 @@ kubectl delete statefulset RELEASE_NAME-loki-distributed-querier -n LOKI_NAMESPA | ingester.maxSurge | int | `0` | Max Surge for ingester pods | | ingester.maxUnavailable | string | `nil` | Pod Disruption Budget maxUnavailable | | ingester.nodeSelector | object | `{}` | Node selector for ingester pods | -| ingester.persistence.claims | list | `[{"name":"data","size":"10Gi","storageClass":null}]` | List of the ingester PVCs @notationType -- list | +| ingester.persistence.claims | list | `[{"name":"data","size":"10Gi","storageClass":null}]` | List of the ingester PVCs | | ingester.persistence.enableStatefulSetAutoDeletePVC | bool | `false` | Enable StatefulSetAutoDeletePVC feature | | ingester.persistence.enabled | bool | `false` | Enable creating PVCs which is required when using boltdb-shipper | | ingester.persistence.inMemory | bool | `false` | Use emptyDir with ramdisk for storage. **Please note that all data in ingester will be lost on pod restart** | diff --git a/charts/loki-distributed/values.yaml b/charts/loki-distributed/values.yaml index 701878dbee..e47e200eea 100644 --- a/charts/loki-distributed/values.yaml +++ b/charts/loki-distributed/values.yaml @@ -502,7 +502,6 @@ ingester: # -- Use emptyDir with ramdisk for storage. **Please note that all data in ingester will be lost on pod restart** inMemory: false # -- List of the ingester PVCs - # @notationType -- list claims: - name: data size: 10Gi @@ -1422,7 +1421,6 @@ compactor: # -- Annotations for compactor PVCs annotations: {} # -- List of the compactor PVCs - # @notationType -- list claims: - name: data size: 10Gi From 1d7a7b41f8fab6288847a46a6e0a8d8415cfedcd Mon Sep 17 00:00:00 2001 From: Stavros Foteinopoulos Date: Wed, 22 Jan 2025 07:50:18 +0200 Subject: [PATCH 3/3] Revert "try to fix docs" This reverts commit 429fbaaace8040096256ae1a883dc0b4a8bd0f7a. --- charts/loki-distributed/README.md | 4 ++-- charts/loki-distributed/values.yaml | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/charts/loki-distributed/README.md b/charts/loki-distributed/README.md index 7018b86bff..8ca6f9552f 100644 --- a/charts/loki-distributed/README.md +++ b/charts/loki-distributed/README.md @@ -114,7 +114,7 @@ kubectl delete statefulset RELEASE_NAME-loki-distributed-querier -n LOKI_NAMESPA | compactor.livenessProbe | object | `{}` | liveness probe settings for ingester pods. If empty use `loki.livenessProbe` | | compactor.nodeSelector | object | `{}` | Node selector for compactor pods | | compactor.persistence.annotations | object | `{}` | Annotations for compactor PVCs | -| compactor.persistence.claims | list | `[{"name":"data","size":"10Gi","storageClass":null}]` | List of the compactor PVCs | +| compactor.persistence.claims | list | `[{"name":"data","size":"10Gi","storageClass":null}]` | List of the compactor PVCs @notationType -- list | | compactor.persistence.enableStatefulSetAutoDeletePVC | bool | `false` | Enable StatefulSetAutoDeletePVC feature | | compactor.persistence.enabled | bool | `false` | Enable creating PVCs for the compactor | | compactor.persistence.size | string | `"10Gi"` | Size of persistent disk | @@ -307,7 +307,7 @@ kubectl delete statefulset RELEASE_NAME-loki-distributed-querier -n LOKI_NAMESPA | ingester.maxSurge | int | `0` | Max Surge for ingester pods | | ingester.maxUnavailable | string | `nil` | Pod Disruption Budget maxUnavailable | | ingester.nodeSelector | object | `{}` | Node selector for ingester pods | -| ingester.persistence.claims | list | `[{"name":"data","size":"10Gi","storageClass":null}]` | List of the ingester PVCs | +| ingester.persistence.claims | list | `[{"name":"data","size":"10Gi","storageClass":null}]` | List of the ingester PVCs @notationType -- list | | ingester.persistence.enableStatefulSetAutoDeletePVC | bool | `false` | Enable StatefulSetAutoDeletePVC feature | | ingester.persistence.enabled | bool | `false` | Enable creating PVCs which is required when using boltdb-shipper | | ingester.persistence.inMemory | bool | `false` | Use emptyDir with ramdisk for storage. **Please note that all data in ingester will be lost on pod restart** | diff --git a/charts/loki-distributed/values.yaml b/charts/loki-distributed/values.yaml index e47e200eea..701878dbee 100644 --- a/charts/loki-distributed/values.yaml +++ b/charts/loki-distributed/values.yaml @@ -502,6 +502,7 @@ ingester: # -- Use emptyDir with ramdisk for storage. **Please note that all data in ingester will be lost on pod restart** inMemory: false # -- List of the ingester PVCs + # @notationType -- list claims: - name: data size: 10Gi @@ -1421,6 +1422,7 @@ compactor: # -- Annotations for compactor PVCs annotations: {} # -- List of the compactor PVCs + # @notationType -- list claims: - name: data size: 10Gi