Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable editing alert rules declared by GrafanaAlertRuleGroup resource #1710

Open
chenlujjj opened this issue Oct 10, 2024 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@chenlujjj
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We used GrafanaAlertRuleGroup CR to manage alert rules, but the rules created can be edited by users from UI, which may make the status inconsistency.

Describe the solution you'd like
Add an option to disable editing alert rules from UI.

@chenlujjj chenlujjj added enhancement New feature or request needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 10, 2024
@chenlujjj
Copy link
Contributor Author

cc @theSuess

@theSuess
Copy link
Member

Thanks for reporting this issue! We are currently focused on the UID refactoring so we won't have time for this soon but are more than happy to review/accept a PR regarding this.

Should be pretty straight forward:

  1. Add the field to the api spec
  2. Set the value of the provenance field accordingly

@theSuess theSuess added good first issue Good for newcomers triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Oct 14, 2024
@chenlujjj
Copy link
Contributor Author

@theSuess Thanks, I can work on it

@chenlujjj
Copy link
Contributor Author

We are currently focused on the UID refactoring

BTW, are you referring to the issue that users must set UID in the CR definition? Previously I assumed the grafana backend can generate those uids

@chenlujjj
Copy link
Contributor Author

Raised a PR: #1715

@chenlujjj
Copy link
Contributor Author

We are currently focused on the UID refactoring

BTW, are you referring to the issue that users must set UID in the CR definition? Previously I assumed the grafana backend can generate those uids

Hi @theSuess , I checked the documentation of provisioning http API: https://grafana.com/docs/grafana/latest/alerting/set-up/provision-alerting-resources/http-api-provisioning/#span-idprovisioned-alert-rulespan-provisionedalertrule, seems that the UID of alert rule is not a REQUIRED field.

Is it possible to omit the uid when declaring CR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants