Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

20240517 prep release #130

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

20240517 prep release #130

wants to merge 22 commits into from

Conversation

briangann
Copy link
Collaborator

@briangann briangann commented May 18, 2024 •
edited
Loading

Remaining issues:

  • GCOM ServiceAccount/Token login failing to load plugins (CSP/Cors Issue?)
  • Mapping old to new config, auto-migration would be ideal

@briangann briangann self-assigned this May 18, 2024
@briangann
Copy link
Collaborator Author

briangann commented May 19, 2024 •
edited
Loading

Please note this is going to introduce breaking changes to current setups, a migration method will be needed to map old to new values.

Configuration options have expanded enough to require a configuration file that is not as "flat" as before.

@github-actions GitHub Actions
Copy link

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 2 weeks if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@github-actions github-actions bot added the stale label Aug 25, 2024
@briangann briangann added no stalebot exempt from stale bot and removed stale labels Sep 22, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Sep 23, 2024

Code Climate has analyzed commit a6c49f8 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.6% (50% is the threshold).

This pull request will bring the total coverage in the repository to 6.7% (-1.0% change).

View more on Code Climate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@briangann briangann

Labels
no stalebot exempt from stale bot
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add option to disable incognito Add option to allow or deny geolocation pop-up in chromedp
1 participant
@briangann