Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpinionatedWatcher] Patch/Updates on Add are read as Add calls #163

Open
IfSentient opened this issue Nov 27, 2023 · 0 comments
Open

[OpinionatedWatcher] Patch/Updates on Add are read as Add calls #163

IfSentient opened this issue Nov 27, 2023 · 0 comments
Labels
area/controller type/bug Something isn't working

Comments

@IfSentient
Copy link
Contributor

When the AddFunc logic in the OpinionatedWatcher contains a Patch or Update to the resource, the finalizer has not yet been added to the resource, so the OpinionatedWatcher reads the update as a resource that was missed (or failed), and propagates it as an Add event instead.

The finalizer is only added after AddFunc succeeds so that it won't be added if the AddFunc logic fails. We should find a way to make sure the OpinionatedWatcher doesn't miscategorize events like this.

@IfSentient IfSentient added type/bug Something isn't working area/controller labels Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/controller type/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant