Topic/refactor grafana agent #154
Conversation
There was a problem hiding this comment.
Nice!
Can you please also add molecule scenarios? (You can take inspiration from the grafana server role)
Also would be nice if you could follow the PEP8 style guide for the variable names, that is to prefix internal variables with underscores.
It helps when reading the code to know if it's a internal variable or a variable that can be overwritten.
It's common that variables in /vars are prefixed with a single underscore _ and then variables that are set at the play level (via register:, etc.) are prefixed with two underscores __
|
I have already molecule scenarios, but didn't pushed them because the setup is with systemd in docker and kind of unstable. aka can crash your host system^^ |
|
Using docker/podman images with systemd in molecule is quite common actually so that shouldn't be an issue. |
|
@gardar yeah I realized that after I implemented my own. I will try to use the one already in place. |
|
@gardar I just tried the already includes molecule. Somehow it always get's stuck at the Gathering Facts for over 10 mins. Did you also ever had those problems? Or maybe any idea what that could be. Edit: Maybe a bit more context is useful I use docker on Arch and molecule with sudo. |
|
There are different reasons I've seen that happen, do you have the molecule docker driver installed? and are the containers running? |
|
@ohdearaugustin can you please rebase? |
ohdearaugustin
force-pushed
the
topic/refactor-grafana-agent
branch
from
3b087a9 to
667c756
Compare
|
Should be rebased now. Didn't yet implement the manual install, just didn't had time unfortunately. |
Complete rewrite of grafana_agent role.
Fix #148