Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the correct Prometheus type automatically #278

Open
sjparkinson opened this issue Oct 14, 2024 · 1 comment
Open

Set the correct Prometheus type automatically #278

sjparkinson opened this issue Oct 14, 2024 · 1 comment

Comments

@sjparkinson
Copy link

Is your feature request related to a problem? Please describe.

When configuring a Amazon Managed Service for Prometheus data source we are asked to select the Prometheus type, and when Cortex is selected the relevant version too. Both of these fields seem unnecessary for the scope of this data source.

Image

Describe the solution you'd like

This plugin should use the correct Prometheus type and Cortex version that best matches AMP, without users having to select the details themselves.

Additional context

  • I understand AMP is running Cortex
  • I am not aware of the version of Cortex being used by AMP
@njvrzm
Copy link
Collaborator

njvrzm commented Oct 21, 2024

Hi @sjparkinson - thanks for pointing this out. That configuration section appears to be left over from when this plugin was split off from the core Prometheus datasource, and is in fact unnecessary. We'll clean that up. In the mean time, you don't actually have to select anything in those fields, you can just leave the placeholders and it will work just fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

No branches or pull requests

2 participants