Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service selection: Move selected services to the top #954

Open
gtk-grafana opened this issue Dec 11, 2024 · 1 comment
Open

Service selection: Move selected services to the top #954

gtk-grafana opened this issue Dec 11, 2024 · 1 comment
Labels

Comments

@gtk-grafana
Copy link
Contributor

gtk-grafana commented Dec 11, 2024

When adding an include filter on the service/ initial label selection scene, there's no visual indication that adding a service via the combobox, or the add to filters button does anything:

Image Image

If we applied include filters with the same label as the user's active tab to the volume query, every include would filter out every other result, and users wouldn't be able to select multiple values for the same label.

So, we should visually differentiate these services (more obviously then changing the + icon to -), by either changing their background color, or putting selected label values in a new section.

@gtk-grafana gtk-grafana added the ui label Dec 11, 2024
@gtk-grafana
Copy link
Contributor Author

@zizzpudding this came from @matyax in the dogfooding session today, would love to mock something up for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant