Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AWS: Panic/exit if can't collect costexplorer data #6

Open
Pokom opened this issue Nov 29, 2023 · 2 comments
Open

AWS: Panic/exit if can't collect costexplorer data #6

Pokom opened this issue Nov 29, 2023 · 2 comments
Labels

Comments

@Pokom
Copy link
Contributor

Pokom commented Nov 29, 2023

We've ran into scenarios where we can't access the costexpolorer API and the application continues running. This happened when upgrading aws-go-sdk-v2 which had a major breaking change and took us the better part of a week to realize it before downgrading the package. One thing I think we can do is when instantiating the costexplorer client is to make a "ping" call to validate we've got a connection. If not, the application should halt and ensure we don't take down the working deployment.

@Pokom Pokom transferred this issue from another repository Nov 29, 2023
@Pokom Pokom changed the title [cloudcost-exporter]: Prevent releases if a metric is absent AWS: Panic/exit if can't collect costexporler data Nov 30, 2023
@Pokom Pokom added the good first issue Good for newcomers label Nov 30, 2023
@paulajulve paulajulve changed the title AWS: Panic/exit if can't collect costexporler data AWS: Panic/exit if can't collect costexporter data Jan 10, 2024
@Pokom Pokom changed the title AWS: Panic/exit if can't collect costexporter data AWS: Panic/exit if can't collect costexplorer data Feb 20, 2024
@ohyesgocool
Copy link
Contributor

Hi @Pokom ,
Shall i pick this up ? If yes you can assign it to me 🙂

@Pokom
Copy link
Contributor Author

Pokom commented Oct 31, 2024

Hi @ohyesgocool let me review this issue and provide a bit better direction. The application has evolved considerably since I created this(It is the 6th issue after all) and I just want to make sure you don't invest time in the wrong direction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants