You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To safe guard cloudcost-exporter from initiating too many external requests that do not get cancelled, there should be a uniform way of passing a Context that has a CancelFunc defined with a sane default. This should start at exporter.go as a parameter with a 1m default set and then passed to each provider that gets created. The provider can then generate a context with a timeout defined on each Collect call and pass this on to the collectors Collect methods.
To achieve this, the collector interface needs to be refactored to have the Collect method accept a context as well.
The text was updated successfully, but these errors were encountered:
To safe guard
cloudcost-exporter
from initiating too many external requests that do not get cancelled, there should be a uniform way of passing a Context that has a CancelFunc defined with a sane default. This should start atexporter.go
as a parameter with a1m
default set and then passed to each provider that gets created. The provider can then generate a context with a timeout defined on eachCollect
call and pass this on to the collectorsCollect
methods.To achieve this, the collector interface needs to be refactored to have the
Collect
method accept a context as well.The text was updated successfully, but these errors were encountered: