From d2e018a5d4d4e2a6bfad3bbdd645379b4af9f219 Mon Sep 17 00:00:00 2001
From: Martijn Evers <94963229+marevers@users.noreply.github.com>
Date: Tue, 14 Jan 2025 15:39:31 +0100
Subject: [PATCH] Add note about preventing self-instrumentation (#1525)

---
 charts/beyla/values.yaml | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/charts/beyla/values.yaml b/charts/beyla/values.yaml
index ecf472911..ba3cb9083 100644
--- a/charts/beyla/values.yaml
+++ b/charts/beyla/values.yaml
@@ -204,6 +204,13 @@ config:
     #     cloud_zone: prod-eu-west-0
     #     cloud_instance_id: 123456
     #     cloud_api_key:
+    ## when supplying a custom discovery configuration it is recommended to add
+    ## the below default excludes because they would be overwritten otherwise.
+    ## these default excludes prevent Beyla from instrumenting itself.
+    ## if omitted, self-instrumentation will be enabled.
+    # discovery:
+    #   exclude_services:
+    #     - exe_path: ".*alloy.*|.*otelcol.*|.*beyla.*"
     attributes:
       kubernetes:
         enable: true
@@ -219,13 +226,13 @@ config:
           not_match: '{kube*,*jaeger-agent*,*prometheus*,*promtail*,*grafana-agent*}'
         k8s_src_owner_name:
           not_match: '{kube*,*jaeger-agent*,*prometheus*,*promtail*,*grafana-agent*}'
-    # to enable network metrics
+    ## to enable network metrics
     # network:
     #   enable: true
     prometheus_export:
       port: 9090
       path: /metrics
-    # to enable internal metrics
+    ## to enable internal metrics
     # internal_metrics:
     #   prometheus:
     #     port: 6060